This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make prev_state field optional
#4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `prev_state` field on events is not specced and so synapse shouldn't explode if an event is missing the field. Fixes #4787
Codecov Report
@@ Coverage Diff @@
## develop #4837 +/- ##
===========================================
+ Coverage 75.34% 75.36% +0.01%
===========================================
Files 340 340
Lines 34920 34918 -2
Branches 5717 5716 -1
===========================================
+ Hits 26312 26317 +5
+ Misses 6999 6991 -8
- Partials 1609 1610 +1 |
richvdh
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
lgtm, though any chance you could also:
- add a comment to the schema or something saying that is_state is no longer used
- turn https://github.com/matrix-org/sytest/tree/rav/remove_prev_state into a PR?
|
Done: matrix-org/sytest#570 |
jevolk
added a commit
to jevolk/charybdis
that referenced
this pull request
Jul 10, 2019
This was referenced May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prev_statefield on events is not specced and so synapse shouldn'texplode if an event is missing the field.
Fixes #4787