This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Split TransactionQueue up #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to use this in queues and things, so it'll be useful to give it more of a structure.
This is mostly a prerequisite for #4730, but also fits with the general theme of "move everything off the master that we possibly can".
This is easier than having to have a million fields keyed on destination.
Codecov Report
@@ Coverage Diff @@
## develop #4855 +/- ##
===========================================
- Coverage 75.34% 75.33% -0.01%
===========================================
Files 340 342 +2
Lines 34939 35020 +81
Branches 5722 5727 +5
===========================================
+ Hits 26324 26384 +60
- Misses 7000 7023 +23
+ Partials 1615 1613 -2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cracked, and split TransactionQueue into three separate classes.
Builds on #4852.
Sorry about the size of this diff. It's mostly just moving things around.