This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add ratelimiting on failed login attempts #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4865 +/- ##
===========================================
+ Coverage 59.57% 59.59% +0.01%
===========================================
Files 326 326
Lines 33921 33925 +4
Branches 5597 5597
===========================================
+ Hits 20209 20218 +9
+ Misses 12298 12294 -4
+ Partials 1414 1413 -1 |
babolivier
force-pushed
the
babolivier/ratelimit-login-failed
branch
from
982837b
to
8812d1d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4821
Add a ratelimiter that denies login requests for a given amount of time if there's been too many failed login attempts for the account the client is trying to log into.