Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add option to disable search room lists #4896

Merged
merged 7 commits into from
Mar 21, 2019

Conversation

erikjohnston
Copy link
Member

This disables both local and remote room list searching.

This disables both local and remote room list searching.
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #4896 into develop will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop    #4896      +/-   ##
===========================================
- Coverage    77.96%   77.94%   -0.02%     
===========================================
  Files          326      326              
  Lines        33958    33967       +9     
  Branches      5601     5604       +3     
===========================================
+ Hits         26474    26476       +2     
- Misses        5863     5870       +7     
  Partials      1621     1621

@erikjohnston erikjohnston requested a review from a team March 19, 2019 17:35
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also disable populating the search tables?

synapse/config/room_directory.py Outdated Show resolved Hide resolved
synapse/config/room_directory.py Outdated Show resolved Hide resolved
synapse/handlers/room_list.py Outdated Show resolved Hide resolved
synapse/config/room_directory.py Outdated Show resolved Hide resolved
@richvdh
Copy link
Member

richvdh commented Mar 19, 2019

also: can haz test?

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 09f991a into develop Mar 21, 2019
@erikjohnston erikjohnston deleted the erikj/disable_room_directory branch January 9, 2020 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants