This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add option to disable search room lists #4896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/disable_room_directory
branch
from
March 19, 2019 16:54
76d7e85
to
7c2f0f7
Compare
This disables both local and remote room list searching.
erikjohnston
force-pushed
the
erikj/disable_room_directory
branch
from
March 19, 2019 17:11
7c2f0f7
to
bf58769
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4896 +/- ##
===========================================
- Coverage 77.96% 77.94% -0.02%
===========================================
Files 326 326
Lines 33958 33967 +9
Branches 5601 5604 +3
===========================================
+ Hits 26474 26476 +2
- Misses 5863 5870 +7
Partials 1621 1621 |
richvdh
previously requested changes
Mar 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we also disable populating the search tables?
also: can haz test? |
richvdh
reviewed
Mar 19, 2019
richvdh
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables both local and remote room list searching.