This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Refactors to replication stream row update/parsing #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow individual stream classes to override how a row is parsed.
We're about to turn it straight into a JSON object anyway so building a ROW_TYPE is a bit pointless, and reduces flexibility in the update_function.
Codecov Report
@@ Coverage Diff @@
## develop #4954 +/- ##
===========================================
+ Coverage 60.44% 60.44% +<.01%
===========================================
Files 331 331
Lines 34100 34102 +2
Branches 5627 5627
===========================================
+ Hits 20612 20614 +2
Misses 12017 12017
Partials 1471 1471 |
erikjohnston
approved these changes
Mar 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip building a ROW_TYPE when building updates: we're about to turn it straight into a JSON object anyway so building a ROW_TYPE is a bit pointless, and reduces flexibility in the update_function.
Add parse_row method to replication stream class: This will allow individual stream classes to override how a row is parsed.
Builds on #4953.