This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove usage of request.postpath #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an undocumented variable in twisted, and relies on the servlet being mounted in the right way. This also breaks getting push rules on workers.
Codecov Report
@@ Coverage Diff @@
## develop #5070 +/- ##
===========================================
- Coverage 61.57% 61.48% -0.09%
===========================================
Files 332 332
Lines 34271 34228 -43
Branches 5651 5647 -4
===========================================
- Hits 21103 21046 -57
- Misses 11653 11674 +21
+ Partials 1515 1508 -7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an undocumented variable in twisted, and relies on the servlet
being mounted in the right way.
This also broke getting push rules on workers. Introduced in #5063
Ideally we would fix this up to not do custom url parsing and instead have it use the regex and/or separate servlets. However, let's just do the quick fix for now