Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve logging when event-signature checking fails #5100

Merged
merged 4 commits into from
Apr 29, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 25, 2019

There are basically two changes here:

  • The change in keyring.py is a refactor of verify_json_objects_for_server, the main purpose of which is that when there are no signatures at all from the relevant server, we shortcut _handle_key_deferred and instead just return a failure which tells us what happened.

  • The changes in federation_base catch the failures returned by verify_json_objects_for_server and turn them into new exceptions which tell you which event caused the problem.

@richvdh richvdh requested a review from a team April 25, 2019 22:14
@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #5100 into develop will decrease coverage by 0.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           develop    #5100      +/-   ##
===========================================
- Coverage    61.67%   61.65%   -0.02%     
===========================================
  Files          334      334              
  Lines        34512    34521       +9     
  Branches      5680     5680              
===========================================
  Hits         21284    21284              
- Misses       11699    11708       +9     
  Partials      1529     1529

@richvdh richvdh merged commit b31cc1c into develop Apr 29, 2019
@richvdh richvdh deleted the rav/verification_hackery branch May 23, 2019 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants