Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix infinite loop in presence handler #5103

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Fix infinite loop in presence handler #5103

merged 1 commit into from
Apr 26, 2019

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 26, 2019

Fixes #5102

@richvdh richvdh requested a review from a team April 26, 2019 10:15
babolivier
babolivier approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@babolivier babolivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #5103 into develop will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #5103      +/-   ##
===========================================
+ Coverage    61.67%   61.67%   +<.01%     
===========================================
  Files          334      334              
  Lines        34512    34514       +2     
  Branches      5680     5681       +1     
===========================================
+ Hits         21284    21288       +4     
+ Misses       11699    11693       -6     
- Partials      1529     1533       +4

@richvdh richvdh merged commit 63b75cf into develop Apr 26, 2019
@richvdh richvdh deleted the rav/fix_notif_loop branch April 26, 2019 11:38
@richvdh richvdh mentioned this pull request May 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@babolivier babolivier babolivier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @babolivier