This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Only count aggregations from distinct senders #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a user isn't allowed to send a single emoji more than once.
Codecov Report
@@ Coverage Diff @@
## develop #5203 +/- ##
===========================================
- Coverage 62.49% 62.42% -0.07%
===========================================
Files 338 338
Lines 35023 34982 -41
Branches 5732 5719 -13
===========================================
- Hits 21888 21838 -50
- Misses 11587 11597 +10
+ Partials 1548 1547 -1 |
richvdh
suggested changes
May 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5195
Otherwise users can send multiple multiple reactions, and that seems silly.
Separately, we want to 4xx on the CS API if a user tries to react with the same emoji multiple times.