Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add quotes around the pip install target to avoid my shell complaining #6855

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Add quotes around the pip install target to avoid my shell complaining #6855

merged 1 commit into from
Feb 5, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Feb 5, 2020

Without this change my shell complains with:

$ python -m pip install --no-use-pep517 -e .[all]
zsh: no matches found: .[all]

@clokep clokep requested a review from a team February 5, 2020 17:51
erikjohnston
erikjohnston approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@clokep clokep merged commit 5e01906 into develop Feb 5, 2020
@clokep clokep deleted the clokep/readme-pip-install branch February 5, 2020 18:29
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge pull request #6855 from matrix-org/clokep/readme-pip-install
62d3277 
* commit '5e019069a':
  Add quotes around pip install target (my shell complained without them).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @erikjohnston