This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow moving group read APIs to workers #6866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/create_group_worker_store
branch
from
February 6, 2020 17:37
6ef0393
to
ef8b865
Compare
erikjohnston
force-pushed
the
erikj/create_group_worker_store
branch
2 times, most recently
from
February 6, 2020 18:03
ac07b27
to
b685d81
Compare
erikjohnston
force-pushed
the
erikj/create_group_worker_store
branch
from
February 6, 2020 18:06
b685d81
to
75f3824
Compare
anoadragon453
approved these changes
Feb 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I assume this won't break existing people's reverse-proxy configs?
You can still run groups on the master process happily, so its fine. |
erikjohnston
added a commit
that referenced
this pull request
Feb 7, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'de2d26737': Allow moving group read APIs to workers (#6866)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: matrix-org/sytest#798
Fixes #6415
Most of this PR is separating the various stores and handlers into what can be run on master and what can be run on workers, i.e. a bunch of cutting and pasting