Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Spell out that the last event sent to a room won't be deleted by a purge #6891

Merged
merged 5 commits into from
Feb 12, 2020

Conversation

babolivier
Copy link
Contributor

@babolivier babolivier commented Feb 11, 2020

Because people can (rightfully) get confused by that, e.g. #3148

@babolivier babolivier requested a review from a team February 11, 2020 17:57
@turt2live
Copy link
Member

@babolivier wrong issue reference?

@babolivier
Copy link
Contributor Author

@turt2live Yep, meant to be #3148, fixed now.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like an improvement, but we probably need to say a bit more than "break the room". Something like "Synapse requires at least one message in each room, so it will never delete the last message in a room." ?

@babolivier
Copy link
Contributor Author

Right, I wanted to keep the doc as low-level as possible wrt the Matrix internals (hence the vague phrasing), but yours works well, I'll update the docs.

@babolivier babolivier requested a review from a team February 12, 2020 15:40
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks brendan

@babolivier babolivier merged commit 6cd34da into develop Feb 12, 2020
@babolivier babolivier deleted the babolivier/retention-doc-amend branch February 12, 2020 20:12
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '6cd34da8b':
  Rephrase
  Update the changelog file
  Also spell it out in the purge history API doc
  Changelog
  Spell out that Synapse never purges the last event sent in a room
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants