Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean up and update federation docs #6940

Merged
merged 9 commits into from
Feb 19, 2020
Merged

Conversation

babolivier
Copy link
Contributor

This is an attempt to fix #6853

These changes are part of the work on #6397, but don't mention ACME at all given these docs are for new installs and the feature doesn't work for them.

What I've done is:

  • Split the delegation docs out of federate.md
  • Remove the documentation on SRV records and replace them with a mention that it's considered an advanced topic and a link to the related section of the spec if people really need it
  • Rewrite the first part of federate.md to look more like a step-by-step guide about how to set up federation
  • Fix links in reverse_proxy.md

@babolivier babolivier requested a review from a team February 18, 2020 14:10
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good. a few nits!

docs/federate.md Outdated Show resolved Hide resolved
docs/federate.md Outdated Show resolved Hide resolved
docs/federate.md Outdated Show resolved Hide resolved
docs/delegate.md Outdated Show resolved Hide resolved
docs/delegate.md Outdated Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, a few more quibbles!

docs/delegate.md Outdated Show resolved Hide resolved
docs/delegate.md Outdated Show resolved Hide resolved
docs/delegate.md Outdated Show resolved Hide resolved
docs/delegate.md Outdated Show resolved Hide resolved
docs/federate.md Outdated Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot

@babolivier babolivier merged commit bbe39f8 into develop Feb 19, 2020
@babolivier babolivier deleted the babolivier/federate.md branch February 19, 2020 10:59
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit 'bbe39f808':
  Incorporate review
  Incorporate review
  Phrasing
  Changelog
  Add mention of SRV records as an advanced topic
  Argh trailing spaces
  Fix links in the reverse proxy doc
  Make federate.md more of a sumary of the steps to follow to set up replication
  Split the delegating documentation out of federate.md and trim it down
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants