Consoliate command formatting helper methods in CommandFormatter #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #21 and introduces the
Airbrussh::CommandFormatter
class. This is a decorator (using Ruby'sSimpleDelegator
) that wraps anSSHKit::Command
to add various formatting helpers.This consolidates all the command-specific formatting logic in one place. Since CommandFormatter is just a bunch of simple string manipulations, it is also very easy to test.
Along the way I also added
Airbrussh::Colors
, which is a very basic implementation of the ANSI color logic we need for Airbrussh, with no external dependencies. This replaces our (undeclared) dependency on thecolorize
gem.