Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat-zksync incompatible currently with latest tenderly-hardhat #998

Open
pcaversaccio opened this issue Apr 6, 2024 · 3 comments
Open

Comments

@pcaversaccio
Copy link
Contributor

pcaversaccio commented Apr 6, 2024

Hey guys, as stated in #240, @openzeppelin/hardhat-upgrades is currently incompatible with hardhat-zksync. It's non-issue until you use the latest tenderly-hardhat version, which requires as one of it's dependencies @openzeppelin/hardhat-upgrades (see here). FWIW, it got added here. Is there any solution planned?

@pcaversaccio pcaversaccio changed the title hardhat-zksync incompatible currently with tenderly-hardhat hardhat-zksync incompatible currently with latest tenderly-hardhat Apr 6, 2024
@nikola-bozin-txfusion
Copy link
Contributor

nikola-bozin-txfusion commented Apr 8, 2024

Hey @pcaversaccio , the main reason this hasn't been bumped yet in our plugin is because when someone uses it in combination with the @matterlabs/zksync-contracts package, it can lead to errors.
This is because the @matterlabs/zksync-contracts package is dependent on older versions of the @openzeppelin contracts.

We've already communicated this issue to the core team, and they've instructed us to wait until the @matterlabs/zksync-contracts package is updated to resolve the compatibility issue.

We hope that this will be resolved in near future.

@pcaversaccio
Copy link
Contributor Author

Hey @pcaversaccio , the main reason this hasn't been bumped yet in our plugin is because when someone uses it in combination with the @matterlabs/zksync-contracts package, it can lead to errors. This is because the @matterlabs/zksync-contracts package is dependent on older versions of the @openzeppelin contracts.

We've already communicated this issue to the core team, and they've instructed us to wait until the @matterlabs/zksync-contracts package is updated to resolve the compatibility issue.

We hope that this will be resolved in near future.

Any update on the progress here?

@nikola-bozin-txfusion
Copy link
Contributor

Hey @pcaversaccio, next week there should probably be a new release of @matterlabs/zksync-contracts package.
In the meantime we will work on updating the @matterlabs/hardhat-zksync-upgradable package to support latest version of OZ contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@pcaversaccio @nikola-bozin-txfusion and others