chore: add tests for paymaster contracts using era-test-node-action #15
Conversation
|
|
||
| - name: Run Tests | ||
| run: | | ||
| yarn ci:tests |
There was a problem hiding this comment.
suggestion: We should consider always printing out the logs of era_test_node in case the tests fail
- name: Era Test Node Logs
if: always()
run: cat ./era_test_node.log
There was a problem hiding this comment.
I think if a job fails it would be best the user updates the action to use logs:debug and then make use of the log file (either cat or artifacts approach) which I don't think should be used by default?
There was a problem hiding this comment.
Up to you really, but I'd also prefer the CI showing test logs by default
|
|
||
| - name: Run Tests | ||
| run: | | ||
| yarn ci:tests |
There was a problem hiding this comment.
Up to you really, but I'd also prefer the CI showing test logs by default
| @@ -0,0 +1,27 @@ | |||
| name: run | |||
There was a problem hiding this comment.
Your steps have such nice capitalised titles and this one's just called "run" 😆
| const zkSyncTestnet = | ||
| process.env.NODE_ENV == "test" | ||
| ? { | ||
| const getNetworkConfig = () => { |
There was a problem hiding this comment.
I like this, we should use this in other examples too come to think of it
Changes introduced in this PR: