Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prover): Use query macro instead string literals for queries #2930

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat(prover): Use query macro instead string literals for queries #2930

merged 1 commit into from
Sep 20, 2024

Conversation

Artemka374
Copy link
Contributor

What ❔

In some places our sqlx queries are using string literals instead of query macros. This PR changes this behaviour in places it is possible.

Why ❔

To prevent possible SQL injections.
It also will cache the queries, which should make them faster.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@EmilLuta
Copy link
Contributor

This is the kind of things that make me day twice better! <3

@Artemka374 Artemka374 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 1cf959d Sep 20, 2024
29 checks passed
@Artemka374 Artemka374 deleted the afo/update-sqlx-queries branch September 20, 2024 11:23
@zksync-era-bot zksync-era-bot mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artemka374 @EmilLuta