Skip to content
This repository has been archived by the owner on Apr 23, 2019. It is now read-only.

username link on issue comments #11

Open
kaos opened this issue Nov 4, 2015 · 6 comments
Open

username link on issue comments #11

kaos opened this issue Nov 4, 2015 · 6 comments

Comments

@kaos
Copy link

kaos commented Nov 4, 2015

seems to always point at gitlab.com/u/...
@NotSqrt
Copy link

NotSqrt commented Nov 4, 2015

Looks like the user url is not in the sent data (https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/web_hooks/web_hooks.md), it will have to be built by extracting the root url from one of the urls sent by the webhook.

@kaos
Copy link
Author

kaos commented Nov 5, 2015

Yep, that would be the fix :)

@jwilander jwilander self-assigned this Nov 5, 2015
@jwilander
Copy link
Member

Yes, I can work on a fix for this in a day or say unless someone else wants to submit a PR for it :)

@kaos
Copy link
Author

kaos commented Nov 5, 2015

I wouldn't mind submitting a PR, but haven't got the time right now...

@NotSqrt
Copy link

NotSqrt commented Nov 5, 2015

I might look into it, and also on #8 , since I'm the one that reported it 😃

@NotSqrt
Copy link

NotSqrt commented Jan 19, 2016

Done in my repository.

@jwilander jwilander removed their assignment Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaos @NotSqrt @jwilander