Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin should require confirmation when building with plugin id "com.mattermost.plugin-starter-template" #152

Open
mickmister opened this issue May 20, 2021 · 4 comments
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Member

When I use the starter template for a new project and deploy the plugin to my environment, it always deploys as Plugin Starter Template with id com.mattermost.plugin-starter-template. This is because I'm not thinking about changing the plugin id when I'm creating a POC.

I propose we make it so running the make deploy command (and others like it that build the plugin) would first ask the user something like:

Are you sure you want to build the plugin with an id of "com.mattermost.plugin-starter-template"? Consider editing plugin.json to configure your project.

@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Type/Enhancement New feature or improvement of existing feature Difficulty/1:Easy Easy ticket labels May 20, 2021
@mickmister
Copy link
Member Author

@hanzei What are your thoughts on this?

@hanzei
Copy link
Contributor

hanzei commented May 20, 2021

@mickmister I don't have objection to this change, but I would suggest to only log a message and don't block the flow of a user.

@haardikdharma10
Copy link
Contributor

Hey @mickmister! This could be a nice addition. @hanzei has a valid point too. Can we change the Makefile wherein we can use $(info message) or $(warning message) in the deploy command, both of which won't stop the execution. If yes, which one do you think will be better to use?

@mickmister
Copy link
Member Author

@haardikdharma10 I agree, and I think using warning makes sense because this message is meant to alert the user to change something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
4 participants