Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can correct_colours be replaced by Poisson Image Editing? #23

Open
shartoo opened this issue Sep 4, 2019 · 5 comments
Open

Can correct_colours be replaced by Poisson Image Editing? #23

shartoo opened this issue Sep 4, 2019 · 5 comments

Comments

@shartoo
Copy link

shartoo commented Sep 4, 2019

Here is a paper Poisson Image Editing

@PapaMadeleine2022
Copy link

@shartoo Hello, do you have tested it ? I find function correct_colours can produce some bad case in which there are some white part on the edge of result face when the two faces have a large color difference.

@shartoo
Copy link
Author

shartoo commented Apr 22, 2020

It's works fine for me. You could try changing the diameter of GaussianBlur

@PapaMadeleine2022
Copy link

@matthewearl thanks for your reply. Increasing diameter of GaussianBlur actually can suppress the white light part, but can not overcome this problem when there are big color differences on same location for two face. Can you give some advises?

@shartoo
Copy link
Author

shartoo commented Apr 24, 2020

The last update of this repo is 5 years ago,so the solution it's outdated, you could learn the idea behind this but not as a final solution. I opened this issue to see if any improvement could make.

@PapaMadeleine2022
Copy link

@shartoo thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants