cargo-changelog currently does not 'bump' versions

[TheNeikos]

Currently, when running cargo changelog create-release minor it does not actually 'bump' versions or anything. It just reads out the current version through this call chain:

cargo-changelog/src/command/create_release_command.rs

Line 14 in cc3f10b

let version_string = find_version_string(workdir, &self.version)?;

Which then calls find_version_string:

cargo-changelog/src/command/common.rs

Lines 32 to 62 in cc3f10b

	pub fn find_version_string(workdir: &Path, version: &VersionSpec) -> Result<String, Error> {
	use cargo_metadata::MetadataCommand;
	if let VersionSpec::Custom { custom } = version {
	Ok(custom.clone())
	} else {
	let metadata = MetadataCommand::new()
	.manifest_path(workdir.join("./Cargo.toml"))
	.exec()?;
	let workspace_member_ids = &metadata.workspace_members;
	let versions = metadata
	.packages
	.iter()
	.filter(|pkg| workspace_member_ids.contains(&pkg.id))
	.map(|pkg| &pkg.version)
	.collect::<Vec<_>>();
	if versions.is_empty() {
	return Err(Error::NoVersionInCargoToml);
	}
	let first = versions[0];
	let all_versions_same = versions.iter().all(|v| *v == first);
	if !all_versions_same {
	return Err(Error::WorkspaceVersionsNotEqual);
	}
	Ok(first.to_string())
	}
	}

This only reads out the version of the Cargo.toml in the project and ultimately returns the first it finds. No bumping or otherwise.

It is unclear to me how to solve this, as cargo-changelog is not a release manager. Hence running cargo changelog create-release major could not do much other than 'trust' the version it is given.

This impacts #239 as that requires the input to be 'truthful' to actually be able to work.

[matthiasbeyer]

🤦

Yeah,... alpha software! 👍

[TheNeikos]

after discussion, we've come to the following conclusion:

• cargo-changelog will not read any Cargo.toml anymore
• The user specifies what version they plan on releasing, the tool then checks the last released version and based on that bumps the version that has been given (major/minor/patch) and puts all the files in there
• It defaults to 0.0.0 and goes on from there (so a minor bump on an empty project will release 0.1.0)
• if custom versions are required, then they can still be given with the custom switch