Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent string interpolation between alembic and mautrix-telegram #362

Closed
serra-allgood opened this issue Sep 9, 2019 · 1 comment
Labels
bug: defect Something isn't working and it never has worked easy Easy to fix, good first contribution
Milestone

Comments

@serra-allgood
Copy link

The password I generated for a telegram postgres role just happened to have a % character in it. I'm assumingalembic uses the old sprintf interpolation syntax because trying to setup the db caused it to throw an error complaining about invalid string interpolation. I was able to work around it by escaping it as %%, but then when starting the bridge, the bridge was unable to auth to postgres because of the extra character. A minor bug, but I felt it worth opening the issue.

@tulir tulir added bug: defect Something isn't working and it never has worked easy Easy to fix, good first contribution labels Sep 9, 2019
@tulir tulir added this to the 0.7.0 milestone Sep 9, 2019
@tulir
Copy link
Member

tulir commented Sep 9, 2019

Yeah, looks like the URI is passed to alembic through its config thing, which supports variable interpolation.

@tulir tulir closed this as completed in 2e28277 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: defect Something isn't working and it never has worked easy Easy to fix, good first contribution
Development

No branches or pull requests

2 participants