Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images with captions don't store Matrix event ID of caption #511

Closed
tulir opened this issue Aug 8, 2020 · 2 comments
Closed

Images with captions don't store Matrix event ID of caption #511

tulir opened this issue Aug 8, 2020 · 2 comments
Labels
bug: defect Something isn't working and it never has worked requires db update Requires a database schema change and migration

Comments

@tulir
Copy link
Member

tulir commented Aug 8, 2020

Currently the database can only store one event ID per Telegram message (except for edits). However, images with captions are bridged as two messages. This means that:

  • Replying to the image event from Matrix won't be bridged correctly
  • Deleting the image event from Matrix won't be bridged correctly
  • Deleting the message from Telegram will only delete the caption

Bridging image messages as inline images is already supported by the bridge, but not supported by most clients. The preferred solution would be implementing matrix-org/matrix-spec-proposals#2530 everywhere, but alternatively the database could be updated to support a many-to-one mapping.
@tulir tulir added requires db update Requires a database schema change and migration bug: defect Something isn't working and it never has worked labels Aug 8, 2020
@tulir tulir added this to the soon-ish™ milestone Aug 8, 2020
This was referenced Aug 8, 2020
Closed
Closed
@JuniorJPDJ
Copy link

What about albums which are also being bridged as 1 telegram message to many matrix messages?

@tulir
Copy link
Member Author

tulir commented Aug 8, 2020

Albums are many messages on telegram

@tulir tulir removed this from the soon-ish™ milestone Jan 31, 2022
@tulir tulir changed the title Images with captions don't store Matrix event ID of image Images with captions don't store Matrix event ID of caption May 28, 2022
@tulir tulir closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: defect Something isn't working and it never has worked requires db update Requires a database schema change and migration
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tulir @JuniorJPDJ