Added very basic terraform fmt runner #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauve
reviewed
Jan 5, 2017
There was a problem hiding this comment.
Really cool, thanks. Before I merge could you please squash "Add initial code plugin." and "Added very basic terraform formatting" ?
Also it would be awesome if the path to terraform could be made configurable, but that is just "would-be-cool"-type of comment so no need to fix.
|
|
||
| function fmt(text: string): Promise<string> { | ||
| return new Promise<string>((resolve, reject) => { | ||
| const child = exec('terraform fmt -', { |
There was a problem hiding this comment.
can we make the path to terraform configurable?
Idea from goMain.ts, it is, as they say pretty horrible.
madssj
force-pushed
the
feature/add-terraform-fmt
branch
from
e975508
to
d816fac
Compare
|
@mauve that should do it. |
madssj
changed the title
|
thanks for your contributions, I will push a new release to the vscode gallery later tonight after writing some changelog, do you mind if I mention you in the releasenotes? |
|
the formatOnSave is kinda bad when you have Auto-Save on is there a hook into editor.action.formatDocument that this could be executed on? |
aeschright
added a commit
that referenced
this pull request
May 29, 2020
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a configuration option for
terraform.formatOnSaveand a little function runningterraform fmt -with the input from the document.Thoughts?