login_required! not working fully with nested routes

[jonner]

If I have a route that's inside a nested router, and I use login_required! to try to protect it, it will pass along the nested uri as the next parameter rather than the full url. For example, with the following untested code snippet:

let nested_router = Router::new().route("/new", get(new_thing))
    .route_layer(login_required!(Backend, login_url = "/login"));

let main_router = Router::new()
    .nest("/foo", nested_router);

When a person is not logged in and visits /foo/new, it sends them to /login?next=%2fnew, rather than /login?next=%2ffoo%2fnew. In other words, it is trying to redirect them back to /new after login rather than /foo/new. So the nested part of the URL gets lost. Is this supposed to work?

[maxcountryman]

The value of next is based on the request URI, as we can see here.

I'm surprised that nesting would affect this and it seems odd that the URI is truncated in that way. I wonder if this is correct behavior for axum.

Regardless, this isn't doing what we would want.

[maxcountryman]

I believe this should address the issue: #153

In a separate branch I'm working on a test suite for the middleware, so I'll cut a patch release and then follow up with a fix for a separate issue as well as a test case covering nested routes.

[jonner]

Thanks. That was quick.

[maxcountryman]

I've published v0.11.1. Do let us know if that doesn't address the issue.

[jonner]

Seems to work, thank you!

[maxcountryman]

I've also added a test case for this now.

Please let us know if you run into any other issues and we'll be happy to take a look.