'FlaskClient' object has no attribute 'get_cookie' and because of that LoginTestCase throws errors

[rafalbraun]

I would like to point out that one of the test classes throws errors because of lacking method - something that I feel could be fixed easily, but I may be wrong and would like to know if it is made like this on purpose (or maybe I run tests wrong). Below is log from my attempt to run tests in LoginTestCase.

/usr/bin/python3.11 ~/.local/share/JetBrains/IdeaIC2023.1/python-ce/helpers/pycharm/_jb_unittest_runner.py --target test_login.LoginTestCase 
Testing started at 1:24 PM ...
Launching unittests with arguments python -m unittest test_login.LoginTestCase in ~/Projects/python/flask-login/tests



Notch != Anonymous

Expected :Anonymous
Actual   :Notch
<Click to see difference>

Traceback (most recent call last):
  File "~/Projects/python/flask-login/tests/test_login.py", line 909, in test_invalid_remember_cookie
    self.assertEqual("Anonymous", result.data.decode("utf-8"))
AssertionError: 'Anonymous' != 'Notch'
- Anonymous
+ Notch



Error
Traceback (most recent call last):
  File "~/Projects/python/flask-login/tests/test_login.py", line 671, in test_remember_me_accepts_duration_as_int
    cookie = c.get_cookie(name, domain)
             ^^^^^^^^^^^^
AttributeError: 'FlaskClient' object has no attribute 'get_cookie'


Error
Traceback (most recent call last):
  File "~/Projects/python/flask-login/tests/test_login.py", line 655, in test_remember_me_custom_duration_uses_custom_cookie
    cookie = c.get_cookie(name, domain, path)
             ^^^^^^^^^^^^
AttributeError: 'FlaskClient' object has no attribute 'get_cookie'


Error
Traceback (most recent call last):
  File "~/Projects/python/flask-login/tests/test_login.py", line 725, in test_remember_me_no_refresh_every_request
    cookie1 = c.get_cookie("remember", domain, path)
              ^^^^^^^^^^^^
AttributeError: 'FlaskClient' object has no attribute 'get_cookie'


Error
Traceback (most recent call last):
  File "~/Projects/python/flask-login/tests/test_login.py", line 742, in test_remember_me_refresh_each_request
    cookie1 = c.get_cookie("remember", domain, path)
              ^^^^^^^^^^^^
AttributeError: 'FlaskClient' object has no attribute 'get_cookie'


Error
Traceback (most recent call last):
  File "~/Projects/python/flask-login/tests/test_login.py", line 639, in test_remember_me_uses_custom_cookie_parameters
    cookie = c.get_cookie(name, domain, path)
             ^^^^^^^^^^^^
AttributeError: 'FlaskClient' object has no attribute 'get_cookie'

[2024-09-04 13:24:47,271] ERROR in app: Exception on /login-notch-remember-custom-invalid [GET]
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/flask_login/utils.py", line 194, in login_user
    duration.microseconds
AttributeError: 'str' object has no attribute 'microseconds'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/flask/app.py", line 2525, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask/app.py", line 1822, in full_dispatch_request
    rv = self.handle_user_exception(e)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask/app.py", line 1820, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask/app.py", line 1796, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/Projects/python/flask-login/tests/test_login.py", line 690, in login_notch_remember_custom_invalid
    return str(login_user(notch, remember=True, duration=duration))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask_login/utils.py", line 198, in login_user
    raise Exception(
Exception: duration must be a datetime.timedelta, instead got: 123
[2024-09-04 13:24:47,283] ERROR in app: Exception on /login-notch-remember [GET]
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/flask_login/login_manager.py", line 488, in _set_cookie
    expires = datetime.utcnow() + duration
              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~
TypeError: unsupported operand type(s) for +: 'datetime.datetime' and 'str'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/flask/app.py", line 2525, in wsgi_app
    response = self.full_dispatch_request()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask/app.py", line 1823, in full_dispatch_request
    return self.finalize_request(rv)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask/app.py", line 1844, in finalize_request
    response = self.process_response(response)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask/app.py", line 2337, in process_response
    response = self.ensure_sync(func)(response)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/flask_login/login_manager.py", line 459, in _update_remember_cookie
    self._set_cookie(response)
  File "/usr/lib/python3/dist-packages/flask_login/login_manager.py", line 490, in _set_cookie
    raise Exception(
Exception: REMEMBER_COOKIE_DURATION must be a datetime.timedelta, instead got: 123


Ran 71 tests in 0.870s

FAILED (failures=1, errors=5)

Process finished with exit code 1