Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDisposable implementations #54

Open
HurryStarfish opened this issue May 20, 2018 · 1 comment
Open

Add IDisposable implementations #54

HurryStarfish opened this issue May 20, 2018 · 1 comment

Comments

@HurryStarfish
Copy link

With the amazing variety of modules in here (most of which I've admittedly never used), it would be good if we could compile a list of classes that would be suitable to be implementing the upcoming IDisposable. Good candidates might be anything that currently has a Delete/Close/Free/Destroy/Release/... method to release unmanaged resources*, but it's hard for me to find/judge modules that I've never used.
So far I've got:

  • the streams from all the SStream modules
  • the various shared memory objects from Interprocess.
  • TDBConnection from the Database module (what about the other classes in there? I don't know, I've never used this)
  • subclasses of the of the above in the various db modules that import Database

Any other suggestions?

* In particular, resources that are limited or potentially have an impact on performance or the outside world (such as network connections) are important. A Delete method that just releases a few small wrapped C objects might not be worth bothering.

@GWRon
Copy link
Contributor

GWRon commented May 20, 2018

Chances are good that sdl.mod has some stuff (outside of bah.mod). Also wx.mod is a candidate having so many stuff in it that the new features might "truncate" stuff needed for the wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants