Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring missing stack definitions for various targets. #2241

Merged
merged 2 commits into from
Jul 25, 2016

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 25, 2016

Those definitions where available in libraries/test/rtos/mbed/* tests but
not in TESTS/mbedmicro-rtos-mbed/* tests.

Those definitions where available in libraries/test/rtos/mbed/* tests but
not in TESTS/mbedmicro-rtos-mbed/* tests.
@pan-
Copy link
Member Author

pan- commented Jul 25, 2016

@0xc0170 @sg-

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2016

+1

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2016

/morph test

@mbed-bot
Copy link

[Build 695]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 509

Test failed!

@sg-
Copy link
Contributor

sg- commented Jul 25, 2016

Serial NC TX failure for NRF51_DK but not for 696 or 694 ?? Seems unrelated. morph failures are single threaded mode running rtos tests

@sg-
Copy link
Contributor

sg- commented Jul 25, 2016

/morph test

@bridadan
Copy link
Contributor

I think these changes are fine for now, but in the future should we look at moving these into the targets.json file or perhaps into a test config file (maybe using mbed_app.json)? I think we want to move away from having target specific code in the tests if at all possible.

@pan-
Copy link
Member Author

pan- commented Jul 25, 2016

@bridadan Is it possible to define a configuration based on the pair target and compiler ?

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 511

Test failed!

@sg- sg- merged commit 0675a58 into ARMmbed:master Jul 25, 2016
@pan- pan- deleted the fix_stack_definitions branch July 3, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants