Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compat versions and Fast tweak for tests to all work #69

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kool7d
Copy link

@kool7d kool7d commented Jun 27, 2023

Updated versions and changed the TensorCast import in the Fast module so that the tests all work. I don't know if correct to do that. TransmuteDims is set to the current version 0.1.15 without the Strided v2 UnsafeStridedView changes in the PR Update Strided dep to v2 #41.

@andrewkhardy
Copy link

Any movement on this @mcabbott ? As it currently stands, I cannot use TensorCast with some more modern packages I need.

@mcabbott
Copy link
Owner

Can you say which packages?

I would prefer not to touch most of these bounds. But e.g. LazyArrays could probably allow 1.0? Haven't tested but would prefer to change exactly one thing at a time.

For Strided.jl, perhaps this package should have no bounds, but Strided v2 needs code changes to TransmuteDims.jl and I haven't got around to figuring them out, sorry. (On that, mcabbott/TransmuteDims.jl#41 and Jutho/Strided.jl#25 are the issues.)

@andrewkhardy
Copy link

It is exactly the Strided v2 code changes I am referring to. It is required by ITensors.

@mcabbott
Copy link
Owner

Forgot about this, sorry. Just pushed 2c500cc to allow Strided@2, needs mcabbott/TransmuteDims.jl#43

Locally, LazyArrays@1 led to an error, let's see what CI thinks.

Test Summary: | Pass  Total   Time
@reduce       |   18     18  12.1s
complex: Test Failed at /Users/me/.julia/dev/TensorCast/test/casting.jl:80
  Expression: A == R .+ C'
   Evaluated: ComplexF64[5.036186709527962 - 0.19500712187403701im 33.62434776231509 - 0.8901324414072603im 10.558992802162038 - 0.6451245256192494im; 19.346451723306124 - 0.30131488503625214im 13.434101724995458 - 0.48432369740022085im 4.044945718340731 - 0.8643411262635937im; 22.656896134071637 - 0.5282954635159289im 16.206193134666705 - 0.23834506667784028im 10.112277104045672 - 0.8818663128297509im] == ComplexF64[5.036186709527962 - 0.19500712187403701im 33.346451723306124 - 0.30131488503625214im 10.656896134071639 - 0.5282954635159289im; 19.62434776231509 - 0.8901324414072603im 13.434101724995458 - 0.48432369740022085im 4.206193134666703 - 0.23834506667784028im; 22.558992802162038 - 0.6451245256192494im 16.04494571834073 - 0.8643411262635937im 10.112277104045672 - 0.8818663128297509im]

Stacktrace:
 [1] macro expansion
   @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
 [2] macro expansion
   @ ~/.julia/dev/TensorCast/test/casting.jl:80 [inlined]
 [3] macro expansion
   @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
 [4] top-level scope
   @ ~/.julia/dev/TensorCast/test/casting.jl:76
complex: Test Failed at /Users/me/.julia/dev/TensorCast/test/casting.jl:83
  Expression: A == (R' .+ conj.(C)) .+ 10im
   Evaluated: ComplexF64[5.036186709527962 + 9.804992878125963im 19.346451723306124 + 9.698685114963748im 22.656896134071637 + 9.47170453648407im; 33.62434776231509 + 9.10986755859274im 13.434101724995458 + 9.515676302599779im 16.206193134666705 + 9.76165493332216im; 10.558992802162038 + 9.354875474380751im 4.044945718340731 + 9.135658873736407im 10.112277104045672 + 9.11813368717025im] == ComplexF64[5.036186709527962 + 9.804992878125963im 19.62434776231509 + 9.10986755859274im 22.558992802162038 + 9.354875474380751im; 33.346451723306124 + 9.698685114963748im 13.434101724995458 + 9.515676302599779im 16.04494571834073 + 9.135658873736407im; 10.656896134071639 + 9.47170453648407im 4.206193134666703 + 9.76165493332216im 10.112277104045672 + 9.11813368717025im]

Stacktrace:
 [1] macro expansion
   @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
 [2] macro expansion
   @ ~/.julia/dev/TensorCast/test/casting.jl:83 [inlined]
 [3] macro expansion
   @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
 [4] top-level scope
   @ ~/.julia/dev/TensorCast/test/casting.jl:76
Test Summary:         | Pass  Fail  Total   Time
@cast                 |   21     2     23  11.5s
  simple broadcasting |    7            7   3.7s
  broadcast reduction |    4            4   2.8s
  complex             |    1     2      3   1.4s
  diag                |    6            6   0.2s
  mapslices etc       |    3            3   3.1s
ERROR: LoadError: Some tests did not pass: 21 passed, 2 failed, 0 errored, 0 broken.

@lpawela
Copy link

lpawela commented Apr 3, 2024

This still does not solve the issue for packages that depend on TensorCast and require new versions of other packages. Are there any plans to merge mcabbott/TransmuteDims.jl#43 soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants