Not correctly sorting when moving to a node with uninitialized sort_order

[elhoyos]

The order of the nodes is not correctly reflected with *siblings* retrieval methods.

[travisbot]

This pull request fails (merged 2f2c53c into c85a605).

[elhoyos]

Adding the following to add_sibling method should be enough

self.order_value = 0 if self.order_value.nil?

But the resultset of

labels(:f3).self_and_siblings.to_a.should

on the first new test keeps failing for me.

Any clue on this?

[mceachen]

The self.order_value.to_i will already return 0 if the order_value is nil, because nil.to_i returns 0.

The problem was that the node that we appended to should have had an order_value set to 0 if we're going to assume the value is equivalent to 0 -- OR we could use an ifnull(), but that smells bad to me.

Thanks for the test, sir! You are a gentleman and a scholar.

[mceachen]

It's fixed in my new branch. I'll release a new version soon.