Allow UUIDs and other types of non-integer primary keys #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matthew,
(In reference to #39)
Here is a starting point to integrate UUIDs. The change to
lib/closure_tree/acts_as_tree.rb
are pretty minimal. I copied most of the tests fromtag_spec
as a starting point, just to make sure everything passed. One or two had to be modified, iearray =~ array
instead ofarray == array
as the natural order of UUIDs is not necessarily the creation order.To be honest rather than copy/pasting, I'd rather simply switch one of the existing models to UUID and keep the same tests, or use something like
[Node, Tag].each {|klass| ...}
.Let me know what you think.
Also, because of the way quoting works, this should allow for binary keys as well, or other types that are neither strings nor integers.