heater: shortcut if sensor is hot enough #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mck1117
reviewed
Nov 12, 2023
| @@ -13,6 +13,10 @@ | |||
| #define ADC_MAX_COUNT (4095) | |||
| #define ADC_OVERSAMPLE 16 | |||
|
|
|||
| // Algo settings | |||
| // TODO: move to settings | |||
| #define HEATER_FAST_HEATING_THRESHOLD_T 550 | |||
There was a problem hiding this comment.
Does this need to be board specific? Why not make generic for all boards?
There was a problem hiding this comment.
- tested only on dual_rev1
- not sure if all boards can measure 550 C. (clamping of input signal on opamp)
mck1117
reviewed
Nov 14, 2023
firmware/heater_control.cpp
Outdated
| @@ -10,6 +10,11 @@ HeaterControllerBase::HeaterControllerBase(int ch) | |||
| { | |||
| } | |||
|
|
|||
| static constexpr int preheatTimeCounter = HEATER_PREHEAT_TIME / HEATER_CONTROL_PERIOD; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.