Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minimum-stability suggestion #8

Closed
luceos opened this issue Aug 30, 2016 · 2 comments
Closed

minimum-stability suggestion #8

luceos opened this issue Aug 30, 2016 · 2 comments

Comments

@luceos
Copy link

luceos commented Aug 30, 2016

Hi, first off great library!

I'd like to point out that setting minimum-stability to dev without adding prefer-stable true is very risky. All dependencies of the composer.json will then be loaded under dev stability, instead of possible stable.
@mcustiel
Copy link
Owner

mcustiel commented Aug 30, 2016 •
edited
Loading

Hello, Daniël. Thank you very much for the suggestion. I did it like that because I have a dependency in master branch of react/http so I needed dev as minimum, but now they removed what I needed so I have to refactor the code and probably will depend in a released version. But I need some time first :) I will keep this open as a reminder to push me and make some time for it.

@mrIncompetent mrIncompetent mentioned this issue Aug 31, 2016
Merged
@mcustiel
Copy link
Owner

Moin, I will close this since it was fixed by @mrIncompetent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luceos @mcustiel