Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong compatibility data for ServiceWorkerRegistration (Safari on macOS) #6557

Closed
fyrk opened this issue Aug 25, 2020 · 2 comments · Fixed by #6622
Closed

Wrong compatibility data for ServiceWorkerRegistration (Safari on macOS) #6557

fyrk opened this issue Aug 25, 2020 · 2 comments · Fixed by #6622
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@fyrk
Copy link
Contributor

fyrk commented Aug 25, 2020

According to web-confluence.appspot.com, the following properties of ServiceWorkerRegistration are not supported by Safari (on macOS):
getNotifications, navigationPreload, paymentMethod and pushManager

However, according to ServiceWorkerRegistration.json, they are all supported since 11.1 or - in case of .paymentMethod - the support is unknown. It looks like this information was mostly added in #1881, which addressed ServiceWorker support in general.

The following table gives an overview of the incorrect data; all of the following properties are not supported by Safari:

Property of ServiceWorkerRegistration Supported according to this repository? Comments
getNotifications 11.1
navigationPreload 11.1 Support for NavigationPreloadManager is currently unknown, this should probably be changed to unsupported as well
paymentManager unknown
pushManager 1.11 The PushManager interface is correctly marked as not supported

If desired, I can try to create a Pull Request to fix the compatibility data.

@fyrk fyrk changed the title ServiceWorkerRegistration.pushManager/.navigationPreload are not supported by Safari Wrong compatibility data for ServiceWorkerRegistration (Safari on macOS) Aug 25, 2020
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 25, 2020
@sideshowbarker
Copy link
Collaborator

If desired, I can try to create a Pull Request to fix the compatibility data.

Yes please — it’d be great if you could create a PR. If you do, I can commit to reviewing it.

@fyrk
Copy link
Contributor Author

fyrk commented Aug 31, 2020

Yes please — it’d be great if you could create a PR. If you do, I can commit to reviewing it.

Here it is, would be nice if you could review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
3 participants