Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bc routines fail to overwrite the existing data and just create a duplicate BC data #32

Closed
anilyil opened this issue Apr 21, 2021 · 0 comments · Fixed by #33
Closed
Assignees
Labels
bug Something isn't working

Comments

@anilyil
Copy link
Contributor

anilyil commented Apr 21, 2021

Description

Some of the internal methods that are supposed to overwrite existing BC information with the new BC information fails to "overwrite" and just end up creating duplicate BC data on these families. As a result, these meshes fail to run in adflow. I think this functionality definitely worked at some point, so I am guessing it will be a relatively minor fix on how we interact with the cgns library.

Steps to reproduce issue

Try to overwrite the BC information on any mesh via overwritebcs. I dont have an exact script ready now, but in the past, I had to first explicitly remove all BCs, and then set the updated ones one by one.

Current behavior

BC info is not overwritten and instead is duplicated.

Expected behavior

BC info should be overwritten so that there is a single BC definition for each face.

@anilyil anilyil self-assigned this Apr 21, 2021
@ewu63 ewu63 added the bug Something isn't working label Apr 22, 2021
@ewu63 ewu63 linked a pull request Apr 23, 2021 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants