Handle backslash escaping in template literals

[ChristopherBiscardi]

There's a bug that exists when <code> children end in \ or have "unicode escape sequence-looking" values like \unlikely\.

I haven't been able to fix it yet, but here's a test that throws when these values are used in code blocks or inline.

It looks like these are the issue-causing sequences, which have been changed since ES2016, but only for tagged template literals. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#Tagged_templates_and_escape_sequences

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

[ChristopherBiscardi]

It looks like changing renderWithReact to replace all \ with \\ works, but this would do it for all content and I assume there's valid cases for unicode escape sequences in markdown bodies.

const jsx = jsxa.replace(/\\/g, "\\\\")

Seems like the solution is to scope it down to happen just inside of code blocks and inline code, but for every \. Does anyone have an opinion on that?

[ghost]

I had similar problem in my case I used Sometext \\ other text inside a markdown table in a markdown file and it was resulting with

<MDXTag>{`Some text `}{`\`}{` other text`}</MDXTag>

which obviously breaks because the {`\`} escapes the ` and so the string is not terminated. Temporarily I carted a md plugin js

const visit = require('unist-util-visit')
// custom plugin to fix mdx->jsx backslask escape {`\`} issue
function fixBasckslashMdPlugin() {
  return tree => visit(tree, 'text', node => {
    if (node.value === '\\') {
      node.value = '\\\\'
    }
  })
}

and put it in my mdx-js/loader in webpack

      {
        test: /.mdx?$/,
        use: [
          'babel-loader',
          {
            loader: '@mdx-js/loader',
            options: {
              mdPlugins: [
                fixBasckslashMdPlugin
              ]
            }
          }
        ]
      },

[ChristopherBiscardi]

this is looking good to me. I've been unable to get it to fail so far.