Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puck.config.tsx not watched by Remix recipe #273

Closed
chrisvxd opened this issue Dec 5, 2023 · 5 comments
Closed

puck.config.tsx not watched by Remix recipe #273

chrisvxd opened this issue Dec 5, 2023 · 5 comments
Assignees
@EarthlingDavey
Labels
good first issue type: bug 🐛

Comments

@chrisvxd
Copy link
Member

chrisvxd commented Dec 5, 2023

Description

Currently, if the user changes their puck.config.tsx in the remix recipe, they must reboot the server.

This is because remix only watches the contents of /app by default.

Proposal

Option 1

Add puck.config.tsx to watchPaths

Option 2

Move puck.config.tsx within the /app directory.
@chrisvxd chrisvxd added ready Assumed ready enough to start type: bug 🐛 good first issue labels Dec 5, 2023
@chrisvxd
Copy link
Member Author

chrisvxd commented Dec 5, 2023

FYI @EarthlingDavey, if you ever do another pass on the remix recipe :)

@EarthlingDavey
Copy link
Contributor

Hi @chrisvxd I'm not 100% set on which option is best.

Keep it in line with the next recipe and go with option 1?

@chrisvxd
Copy link
Member Author

chrisvxd commented Dec 6, 2023

I think I'd go with option 1!

@EarthlingDavey
Copy link
Contributor

Like last time, should I make a PRs into the main branch?

@EarthlingDavey EarthlingDavey mentioned this issue Dec 7, 2023
Merged
@chrisvxd chrisvxd added in progress and removed ready Assumed ready enough to start labels Dec 8, 2023
@chrisvxd
Copy link
Member Author

Closed by #279. Thanks @EarthlingDavey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EarthlingDavey EarthlingDavey

Labels
good first issue type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisvxd @EarthlingDavey