Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility - [IOS] [Safari] - The visible QR box region and canvas are not aligned #21

Closed
mebjas opened this issue Apr 11, 2020 · 4 comments

Comments

@mebjas
Copy link
Owner

mebjas commented Apr 11, 2020

Describe the bug
The region visible under the qrbox (region other than the shaded region) is not exactly aligned with the what is printed on canvas leading to bad UX during scanning.

Describe the browser:

  • OS: IOS
  • Browser Safari
  • Version Latest

Additional context

  • To reproduce make the canvas visible and see the output.
  • Validate this for other android browsers as well.
@mebjas
Copy link
Owner Author

mebjas commented Apr 11, 2020

The canvas drawn is purely based on some predetermined width and height, while the video feed has it's own dimension.

Use

stream.getTracks()[0].getCapabilities()

To get information on this. Ideally the viewfinder should show only this and the shaded region should be constrained within this.

Add a configurable property to begin with

@mebjas
Copy link
Owner Author

mebjas commented May 1, 2020

Screenshot 2020-05-01 at 1 37 38 PM

The bug is high priority for mobile devices as the region shown on viewfinder is not same as the one being sensed by the Qr code scanner.

@mebjas
Copy link
Owner Author

mebjas commented May 1, 2020

Validate on web, the regions are not same.

@mebjas
Copy link
Owner Author

mebjas commented May 1, 2020

Marking as fixed

@mebjas mebjas closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant