Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty span with 10px margin-right when only one camera #599

Open
adamwolf opened this issue Nov 14, 2022 · 1 comment
Open

Empty span with 10px margin-right when only one camera #599

adamwolf opened this issue Nov 14, 2022 · 1 comment

Comments

@adamwolf
Copy link
Contributor

Describe the bug

I think this is a pretty great library--nice work!

I'm using the html5 qrcode scanner. Next to the "Stop Scanning" button, there's a span with a 10px right margin that contains html5-qrcode-scanner-select--which is display:none because there's only one camera on this device.

Would it make sense to remove this? Maybe put display:none on the parent span, or change where the margin is, or just not add it?

I have a branch where I hide the parent span, if you'd want a PR.

To Reproduce
Steps to reproduce the behavior:

  1. Create an html5 qrcode scanner.
  2. Start scanning on a device with one camera.
  3. Go into devtools and look at the Stop Scanning button.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@mebjas
Copy link
Owner

mebjas commented Nov 16, 2022

Good catch, I missed testing this scenario.

I have a branch where I hide the parent span, if you'd want a PR.

Please feel free to send a PR, happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants