-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a second menu can break the "layer". #105
Comments
thank you for reporting that - it's fixed… |
Hi, TypeError: root.$layer is undefined |
I am not getting that error anymore. What browser are you using? http://medialize.github.com/jQuery-contextMenu/demo/on-dom-element.html works for me… |
Hi please look at this script i just create for you. |
can't open that link… |
http://hddezign.com/contextMenu/ |
you can download the code here: |
You should seriously reconsider your approach… Don't have your |
(I applied that change to your code and it worked for me) But you did find a bug: #110 |
I can reliably reproduce the issue on this very page: http://medialize.github.com/jQuery-contextMenu/demo/on-dom-element.html by right-clicking rapidly (or not so rapidly on slower machine/when the CPU usage is high) multiple times. I would suggest adding checks to ensure that the $layer is defined before calling the hide(). |
Issue can be reproduced, like robertoea wrote. [...]
// find the element that would've been clicked, wasn't the layer in the way
if (document.elementFromPoint) {
root.$layer.hide(); // <-- here, line 367
[...] Could You verify it, please? |
Can anyone help with this bug. I get the same error if I click out of term. also I keep seeing this |
Was able to reproduce this as well. For the 'finite' error, something like this helps: https://gist.github.com/Lajnold/5404556 Of course, the $root.layer problem is on that path and will still occur. I'll try and create a patch for this, which may involve having to read the source code. |
I am testing the demo at http://medialize.github.com/jQuery-contextMenu/demo/on-dom-element.html, and have encountered an issue.
The first menu closes, and the second menu pops up, but only for a moment. After that, nothing on the page can be clicked. When clicking anywhere at this stage, the error log in Firefox says:
Error: TypeError: root.$layer is undefined Source File: http://medialize.github.com/jQuery-contextMenu/src/jquery.contextMenu.js Line: 362
The text was updated successfully, but these errors were encountered: