-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an async mode #17
Comments
@meeb I would like to work on a PR for this, is this something you would be interested in working on together/is this already being worked on? |
Thanks for the offer! You're welcome to attempt to work on a PR for this and I'm happy to accept any well formatted contributions. I've been bottle-necked with other work for some time. What I was planning on doing for this was use The complication here is the requirement to support an optional decrease in SSL cipher suite strength to accommodate some of the more esoteric and legacy RDAP endpoints that exist (support for the Most of the time for this issue is going to be spent on regression testing, test suites and reading into the internals of From memory I believe this is going to be replacing the requests |
Thanks to @sam-kleiner this is now implemented in the new v3.0.0 release. |
As all remote interactions from
whoisit
are just basic HTTP requests, with the exception of the additional custom SSL handshake options, an interface should be added to expose an async mode.aiohttp
would be a reasonably low overhead drop-in replacement for the currentrequests
sessions. This would add an extra dependency onaiohttp
and thataiohttp
has compiled extensions so async mode would need to be opt-in to maintain pure Python support.The text was updated successfully, but these errors were encountered: