Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible endpoint-factory API #242

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

possible endpoint-factory API #242

wants to merge 1 commit into from

Conversation

meejah
Copy link
Owner

@meejah meejah commented Jul 22, 2017

A way to give a completely synchronous Endpoint-returning API for use by "startup"-type code (e.g. before the reactor has been started).

A use-case would be to parse configuration and create endpoints prior to the reactor starting.

@coveralls
Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage decreased (-1.1%) to 98.844% when pulling ca3ec5c on tor-endpoint-manager into 4193b00 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 98.844% when pulling ca3ec5c on tor-endpoint-manager into 4193b00 on master.

@codecov-io
Copy link

Codecov Report

Merging #242 into master will decrease coverage by 1.1%.
The diff coverage is 31.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   99.94%   98.84%   -1.11%     
==========================================
  Files          20       20              
  Lines        3662     3721      +59     
==========================================
+ Hits         3660     3678      +18     
- Misses          2       43      +41
Impacted Files Coverage Δ
txtorcon/controller.py 89.56% <31.66%> (-10.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4193b00...ca3ec5c. Read the comment docs.

@meejah
Copy link
Owner Author

meejah commented Jul 26, 2018

@warner any opinions? would this have made Foolscap's tor-support easier..?

@meejah meejah marked this pull request as draft August 17, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants