fix(menu): move update check execution in to the main process

meetalva · Jan 13, 2018 · 7f8ce94 · 7f8ce94
1 parent c0725a6
commit 7f8ce94
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/electron/electron.ts b/src/electron/electron.ts
@@ -1,5 +1,5 @@
 import { checkForUpdates } from './auto-updater';
-import { app, BrowserWindow } from 'electron';
+import { app, BrowserWindow, ipcMain } from 'electron';
 import * as PathUtils from 'path';
 import * as url from 'url';
 
@@ -85,3 +85,9 @@ app.on('activate', () => {
 		createWindow();
 	}
 });
+
+ipcMain.on('request-check-for-updates', () => {
+	if (win) {
+		checkForUpdates(win);
+	}
+});
diff --git a/src/electron/menu.ts b/src/electron/menu.ts
@@ -1,5 +1,11 @@
-import { checkForUpdates } from './auto-updater';
-import { BrowserWindow, MenuItem, MenuItemConstructorOptions, remote, WebContents } from 'electron';
+import {
+	BrowserWindow,
+	ipcRenderer,
+	MenuItem,
+	MenuItemConstructorOptions,
+	remote,
+	WebContents
+} from 'electron';
 import * as FileExtraUtils from 'fs-extra';
 import { PageElement } from '../store/page/page_element';
 import * as PathUtils from 'path';
@@ -279,7 +285,7 @@ export function createMenu(store: Store): void {
 				{
 					label: 'Check for Updates',
 					click: () => {
-						checkForUpdates(remote.getCurrentWindow());
+						ipcRenderer.send('request-check-for-updates');
 					}
 				},
 				{