fix: hold on to legacy prop references

meetalva · Sep 10, 2018 · ead0750 · ead0750
1 parent cd0dd79
commit ead0750
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 5 deletions.
diff --git a/src/model/element/element-property/element-property.ts b/src/model/element/element-property/element-property.ts
@@ -81,11 +81,13 @@ export class ElementProperty {
 
 	public static fromPatternProperty(
 		patternProperty: AnyPatternProperty,
-		context: ElementPropertyContext
+		context: ElementPropertyContext & { LEGACY_ID?: string }
 	): ElementProperty {
 		return new ElementProperty(
 			{
-				id: uuid.v4(),
+				id: context.LEGACY_ID
+					? context.LEGACY_ID
+					: [context.element.getId(), patternProperty.getId()].join('-'),
 				patternPropertyId: patternProperty.getId()
 			},
 			context

diff --git a/src/model/element/element.ts b/src/model/element/element.ts
@@ -21,8 +21,7 @@ export interface ElementInit {
 	open: boolean;
 	patternId: string;
 	placeholderHighlighted: boolean;
-	// tslint:disable-next-line:no-any
-	propertyValues: [string, any][];
+	propertyValues: [string, Types.ElementPropertyValue][];
 	role?: Types.ElementRole;
 	selected: boolean;
 	setDefaults?: boolean;
@@ -71,6 +70,12 @@ export class Element {
 
 	@Mobx.observable private selected: boolean;
 
+	/**
+	/* TODO: Remove before beta
+	/* Keep backward compat
+	/*/
+	private readonly LEGACY_elementPropertyIds: Map<string, string> = new Map();
+
 	@Mobx.computed
 	private get mayHighiglight(): boolean {
 		if (!this.page || !this.page.getActive()) {
@@ -130,6 +135,7 @@ export class Element {
 	private get properties(): ElementProperty[] {
 		return this.patternProperties.map(patternProperty =>
 			ElementProperty.fromPatternProperty(patternProperty, {
+				LEGACY_ID: this.LEGACY_elementPropertyIds.get(patternProperty.getId()),
 				element: this,
 				project: this.project
 			})
@@ -186,10 +192,14 @@ export class Element {
 			context
 		);
 
-		// Keep backward compat
+		/**
+		 * TODO: Remove before beta
+		 * Keep backward compat
+		 */
 		if (Array.isArray(serialized.properties)) {
 			serialized.properties.forEach((property: Types.LegacySerializedElementProperty) => {
 				element.setPropertyValue(property.patternPropertyId, property.value);
+				element.LEGACY_elementPropertyIds.set(property.patternPropertyId, property.id);
 			});
 		}
 

diff --git a/src/types/serialized-model.ts b/src/types/serialized-model.ts
@@ -139,6 +139,11 @@ export interface SerializedElement {
 	selected: boolean;
 }
 
+export interface SerializedElementValue {
+	id: string;
+	value: Types.ElementPropertyValue;
+}
+
 export interface SerializedElementContent {
 	model: Types.ModelName.ElementContent;
 	elementIds: string[];