This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat(component/app): add spacing to page list #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmx
suggested changes
Dec 20, 2017
src/component/app.tsx
Outdated
| @@ -93,7 +93,9 @@ class App extends React.Component<AppProps> { | |||
| <MainArea> | |||
| <SideBar directionVertical hasPaddings> | |||
| <ElementPane> | |||
| <PageList store={this.props.store} /> | |||
| <Space sizeBottom={SpaceSize.XL}> | |||
There was a problem hiding this comment.
Can we set a L space instead of XL?
There was a problem hiding this comment.
Done. Please squash and merge :)
tilmx
approved these changes
Dec 20, 2017
Palmaswell
pushed a commit
that referenced
this pull request
Feb 15, 2018
* feat(component/app): add spacing to page list * feat(component): change space size to l
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.