Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

feat: implement static html export #414

Merged
merged 7 commits into from
May 7, 2018
Merged

feat: implement static html export #414

merged 7 commits into from
May 7, 2018

Conversation

marionebl
Copy link
Contributor

@marionebl marionebl commented May 2, 2018 •
edited by tilmx
Loading

This introduces a Export to HTML feature that enables export of the pages in the currently active project.

  • All pages of the given project
  • Generate a single HTML file with default name of the current
  • Navigate index-based through pages #page-1 through #page-[n]
  • Navigate id-based through pages #[id]
Screencast

html-export

Fixes #72

@marionebl marionebl force-pushed the feat/export-to-html branch 2 times, most recently from a9c3b55 to c1e75b5 Compare May 2, 2018 15:04
@tilmx
Copy link
Member

tilmx commented May 3, 2018

Yippie! Works really well for me!

tilmx
tilmx suggested changes May 4, 2018
View reviewed changes
Copy link
Member

@tilmx tilmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool out of a UX/Design perspective – I only have two comments. Thanks so much!

src/preview/preview-document.ts Outdated
<html>
<head>
<meta charset="utf-8"/>
<title>alva&trade;</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn’t it be cooler to have the project name as title?

src/preview/preview-document.ts
@@ -9,82 +101,21 @@ export const previewDocument = `<!doctype html>
</style>
</head>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about including a <meta name="viewport" content="width=device-width, initial-scale=1.0"> so the export is shown correctly on mobile phones?

@TheReincarnator
Copy link
Contributor

Superseded by #421.

@TheReincarnator TheReincarnator mentioned this pull request May 4, 2018
Closed
@marionebl marionebl reopened this May 7, 2018
@marionebl
Copy link
Contributor Author

Reopening this to address review points from #421. Events will be landed separately.

@TheReincarnator
Copy link
Contributor

Please note that, when merging this instead of #421, the contents of #421 are harder to integrate. Plus, I did bugfixing in #421's HTML-export commit that are not included here.

@TheReincarnator
Copy link
Contributor

Please note that, when merging this instead of #421, the contents of #421 are harder to integrate. Plus, I did bugfixing in #421's HTML-export commit that are not included here.

@TheReincarnator
Copy link
Contributor

Sorry, did not want to close, pressed wrong button.

@marionebl
Copy link
Contributor Author

@TheReincarnator Please note that, when merging this instead of #421, the contents of #421 are harder to integrate. Plus, I did bugfixing in #421's HTML-export commit that are not included here.

Thanks for pointing this out. 👍 I am aware #421 will be harder to integrate. I guess we will port over your changes to a new PR manually to get a full grasp on what will change why.

tilmx
tilmx previously approved these changes May 7, 2018
View reviewed changes
@tilmx
Copy link
Member

tilmx commented May 7, 2018

Can we name the menu as "Export Project as HTML" and the others "Export Page as..." with a seperation line between page and project actions? @marionebl

@tilmx tilmx merged commit 948111f into master May 7, 2018
@tilmx tilmx deleted the feat/export-to-html branch May 7, 2018 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tilmx tilmx tilmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marionebl @tilmx @TheReincarnator