Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

fix: execute custom keyboard handlers when iframe has focus #465

Merged
merged 2 commits into from
May 27, 2018
Merged

fix: execute custom keyboard handlers when iframe has focus #465

merged 2 commits into from
May 27, 2018

Conversation

marionebl
Copy link
Contributor

closes #464

tilmx
tilmx suggested changes May 26, 2018
View reviewed changes
Copy link
Member

@tilmx tilmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Copying/Pasting of property values unfortunately doesn’t work anymore. It now works with the entire element instead of just the selected text. Could you have a look at that?

@marionebl marionebl force-pushed the fix/enable-keyboard-handlers-for-preview branch from 8c8952d to 3c02ab1 Compare May 27, 2018 12:19
@tilmx tilmx merged commit f64ef9c into master May 27, 2018
@tilmx tilmx deleted the fix/enable-keyboard-handlers-for-preview branch May 27, 2018 12:28
markusoelhafen pushed a commit that referenced this pull request Jun 12, 2018
@marionebl
fix: execute custom keyboard handlers when iframe has focus (#465)
9a6ebf5 
closes #464
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tilmx tilmx tilmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit shortcuts do not work for selections originating from preview
2 participants
@marionebl @tilmx