This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: make sidebars resizeable #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmx
approved these changes
May 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the preview resizing in favor of resizable sidebars. It is a first shot at #178, implementing the raw resizing functionality.
Went with this implementation because I had to touch the preview pane while implementing a mirror iframe that will be used to measure drop zone sizes etc.
Includes
Left for later PRs
Possibility to toggle display of sidebars
Persistence of sidebar width
Prepares work on Indicate drop zone on Preview #449
Partially tackles Resize and Hide Left/Right Panels? #178
Screencast