Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

fix(exporter): trigger a second png export if the first does not retu… #497

Merged
merged 1 commit into from
May 31, 2018
Merged

fix(exporter): trigger a second png export if the first does not retu… #497

merged 1 commit into from
May 31, 2018

Conversation

lkuechler
Copy link
Member

…rn a valid value

@lkuechler
Copy link
Member Author

This is not a very good solution but the event for the finished loading fires to early and there seem to be a bug in electron with a timeout combined with a webview

@marionebl marionebl merged commit 000565e into master May 31, 2018
@marionebl marionebl deleted the task/fix-png-export branch May 31, 2018 12:05
markusoelhafen pushed a commit that referenced this pull request Jun 12, 2018
@lkuechler
fix: trigger a second png export if the first does not return a valid…
761e407 
… value (#497)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marionebl marionebl marionebl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkuechler @marionebl