This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: move page overview to sidebar #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmx
changed the title
marionebl
reviewed
Jun 12, 2018
src/components/add-page/demo.tsx
Outdated
| import * as React from 'react'; | ||
| import { AddPage } from '.'; | ||
|
|
||
| const AddPageDemo: React.StatelessComponent<void> = (): JSX.Element => ( |
There was a problem hiding this comment.
Omit the void type parameter
marionebl
reviewed
Jun 12, 2018
src/components/add-page/demo.tsx
Outdated
| import { AddPage } from '.'; | ||
|
|
||
| const AddPageDemo: React.StatelessComponent<void> = (): JSX.Element => ( | ||
| <DemoContainer title="Floating Button"> |
marionebl
reviewed
Jun 12, 2018
src/components/add-page/pattern.json
Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "add-page", | |||
There was a problem hiding this comment.
add-page-button might be a more distinct name
marionebl
reviewed
Jun 12, 2018
src/components/element/index.tsx
Outdated
| } | ||
|
|
||
| export interface ElementProps { | ||
| children?: React.ReactNode; | ||
| draggable: boolean; | ||
| dragging: boolean; | ||
| editable?: boolean; |
There was a problem hiding this comment.
Is this required on top of State.Editable? It might be less confusing to make focused the boolean flag instead.
marionebl
reviewed
Jun 12, 2018
| store.getActiveAppView() === Types.AlvaView.Pages | ||
| ? Types.AlvaView.PageDetail | ||
| : Types.AlvaView.Pages; | ||
| const next = store.getShowPages() ? false : true; |
marionebl
reviewed
Jun 12, 2018
| return ( | ||
| <ViewButton | ||
| title={title} | ||
| onClick={() => store.setShowPages(next)} |
There was a problem hiding this comment.
store.setShowPages(!store.getShowPages())
marionebl
reviewed
Jun 12, 2018
| @@ -30,6 +30,7 @@ export class ElementContainer extends React.Component<ElementContainerProps> { | |||
| <Components.Element | |||
| draggable={true} | |||
| dragging={store.getDragging()} | |||
| editable={props.element.getRole() === ElementRole.Root ? false : true} | |||
There was a problem hiding this comment.
props.element.getRole() !== ElementRole.Root
marionebl
reviewed
Jun 12, 2018
| @@ -38,7 +39,7 @@ export class ElementContainer extends React.Component<ElementContainerProps> { | |||
| onChange={AlvaUtil.noop} | |||
| placeholderHighlighted={props.element.getPlaceholderHighlighted()} | |||
| state={getState(props.element, store)} | |||
| title={props.element.getName()} | |||
| title={props.element.getRole() === ElementRole.Root ? 'Page' : props.element.getName()} | |||
There was a problem hiding this comment.
Let's use the page name for the root element, should be implemented in Element.prototype.getName
marionebl
reviewed
Jun 12, 2018
| <Layout wrap={LayoutWrap.Wrap}> | ||
| {project | ||
| .getPages() | ||
| .map((page, i) => ( |
There was a problem hiding this comment.
Change to map(page => {...})
marionebl
reviewed
Jun 12, 2018
| import * as MobxReact from 'mobx-react'; | ||
| import { Page } from '../../model'; | ||
| import * as React from 'react'; | ||
| import { ViewStore } from '../../store'; | ||
| import * as Types from '../../types'; | ||
|
|
||
| export interface PageTileContainerProps { | ||
| focused: boolean; | ||
| focus: boolean; |
marionebl
previously approved these changes
Jun 13, 2018
marionebl
approved these changes
Jun 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier page switches I moved the page overview to the left sidebar. Now you can easily switch between pages – like in Apple Keynote e.g.
Content
focusedItem)Todo
Make entire page tile editable(Coming with PR feat(editable-title): make page title editable #553)Bugs